![]() ![]() This way the 3rd party service will only ever see the IP of your server, not your client, and you can choose exactly what data from the client you pass through. Parse the response from there and create a response suitable for your client.On your server side, make a request (using an HTTP library, such as Guzzle) to the 3rd party service to get whatever is needed. Information about the application, settings and environment Expand QOwnNotes Debug Information General Info.I do the latter to provide a proxied service to. You can get a web server such as Nginx or Apache to act as a proxy directly through config options, or you can do it via scripting with PHP or whatever. Removing default getters/setters could greatly reduce code bloat and improve readability and if some additional behavior would be needed - option. You could do it with a VPN, but that's overkill, and requires considerable setup on the client side which you don't control. It seems like in most of places getter/setter pair could be replaced with simple call to member variable (instead of calling tVariable (newValue) we could just object.variable newValue ). As nice as having a package manager sounds to me, I don't know if I currently have the time to make and support that transition.Yes, proxying is the right way to do this. The price would be that everyone (contributes) and everywhere (build systems on many platforms and architectures) another 3rd party would be needed to build the app. Usually such PRs come with lots of regressions, some of them not found for a year □ I wish there would be a (free) QWidget UI end2end test tool for Qt. Will try to provide some examples of integration of QOwnNotes with conan after finishing getters/setters cleanup Loss of git blame is unfortunate, that is true, but I guess this information still could be retrieved from commits before beautifying (would not be so comfortable to do so, but still possible) ![]() QOwnNotes is a plain-text file notepad and todo-list manager with markdown support and Nextcloud / ownCloud integration. It is really easy to setup and control versions used as all libraries and their versions are in one config file, as well as then there is no need for having libraries directory in srcĪt work we use uncrustify together with pre-commit but even some simple clang-format should suffice. More than 94 million people use GitHub to discover, fork, and contribute to over 330 million projects. ![]() I have started such refactor here: touching only getters/setters without any additional logicĬonan could be used for fetching external dependencies, for example. do you have one in mind? downside of doing that to the current code-base would be loosing all the git blame status. Installation Changelog Issues Releases Documentation IRC Chat Gitter Chat. Have you thought about code formatting tools? Currently different parts of sources are formatted differently In addition, there also is a Release RSS Feed and an implementation of the legacy update checking api for older versions of QOwnNotes. what do you want to use it for? publishing QOwnNotes or fetching external dependencies? (which there currently are none but those directly added via git-submodule) REST Web API used by QOwnNotes for checking if there is a new release and what the changes were. Have you thought about package manager like conan? If you want you can check how often something else is done with the variable. Sometimes setters or getters also do some addition stuff, I don't know if it's worth to migrate that all without breaking anything. QOwnNotes is now also built with Qt 5.7 to allow Windows XP users to still use it. Removing default getters/setters could greatly reduce code bloat and improve readability and if some additional behavior would be needed - option to add getter/setter is always there Is that a convention or is there some reason for such structure? It seems like in most of places getter/setter pair could be replaced with simple call to member variable (instead of calling tVariable(newValue) we could just object.variable = newValue ). ![]() 2.Open the same markdown file in notepad editor. There are lot of default one-line getters/setters. When I modify the markdown content externally, QOwnNotes taking crashes.(no response) I can not do anything but kill QOwnNotes.I can not reproduce every times.But it often happens.Looks like the CPU is full. Thank you for your concern with the code base! Meaning that Qownnotes already have everything needed for this future, it only needs the ability to preview the links visually. ![]()
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |